Fix bundler installation shell command #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickjj
added a commit
that referenced
this pull request
Apr 27, 2015
Fix bundler installation shell command
|
Good catch, it's been released into |
Merged
gildegoma
added a commit
to dispansible/rvm1-ansible-role
that referenced
this pull request
Jun 30, 2015
Without this change, the Bundler installation introduced by rvm#40 and rvm#41 fails when the `rvm_rubies` list contains valid RVM aliases, like following examples: - ruby-1.9.3 (→ ruby-1.9.3-p551) - ruby-2.0 (→ ruby-2.0.0-p643) - 2.1 (→ ruby-2.1.5) - ruby (→ ruby-2.2.0) - jruby (→ jruby-1.7.18) - etc. Add more test coverage to `.travis.yml`.
gildegoma
added a commit
to dispansible/rvm1-ansible-role
that referenced
this pull request
Jun 30, 2015
Without this change, the Bundler installation introduced by rvm#40 and rvm#41 fails when the `rvm_rubies` list contains valid RVM aliases, like following examples: - ruby-1.9.3 (→ ruby-1.9.3-p551) - ruby-2.0 (→ ruby-2.0.0-p643) - 2.1 (→ ruby-2.1.5) - ruby (→ ruby-2.2.0) - jruby (→ jruby-1.7.18) - etc. Add more test coverage to `.travis.yml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check gem list for specified ruby, not a default system's one.