Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyper integration #1820

Closed
wants to merge 2 commits into from
Closed

Add hyper integration #1820

wants to merge 2 commits into from

Conversation

MikailBag
Copy link
Contributor

Solves #1070 without exposing too many APIs

@svenstaro
Copy link

This would be great to have. I'm currently trying to integrate Sentry but there's no single future I can call to attach the Hub to via bind_hub() so the integration is very lackluster right now. Also for tracing this would be really nice to have.

@SergioBenitez
Copy link
Member

My apologies for coming to this a year and a half later.

I don't think exposing hyper types is the approach we want to take on this one. I think the approach we want to take is one significantly less heavy-handed. Something like:

rocket::build()
    .listen(anything_implementing_listener)

One of the issues with doing this before was configuration. Given the monumental improvements in configuration, I think we can now say that the proper approach here would be to allow the listener to configure itself. The default TCP/TLS listener would read values as it does today, but otherwise the listener can do whatever it wants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants