-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom file extensions #62
Add support for custom file extensions #62
Conversation
I'm a bit worried about this being a breaking change. Landing this would mean existing codemods would now be running against non-js files (and would almost certainly error when ran). I wonder if we can have the host codemod-cli project specifically opt-in to the extensions it supports. Either by having them pass that info in when calling What do you think? |
Sounds good, check my update ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a test and some README changes to explain how to use custom file types.
Should be good to go once CI is happy...
I've updated this to instead add an extra argument to the end (instead of being "inside" the I want to do that separately though so that I can ensure that existing support still works, and new projects get generated with the POJO syntax. |
No description provided.