Add support for using $ as a separator in addition to ::.
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
add-sigil-support
branch
from
f55e924 to
4fba465
Compare
Since Ember has decided to repurpose the `::` sigil to mean "nested folder invocation" (see emberjs/rfcs#457), this introduces `$` as a replacement sigil. Ultimately, usage of `::` will be deprecated by this addon (though that will be in a future commit).
rwjblue
force-pushed
the
add-sigil-support
branch
from
4fba465 to
2b1cb7b
Compare
Skip tests for invoking angle bracket components due to incompatibilities with ember-angle-bracket-invocation-polyfill 1.3 and higher (since it added support for `::` syntax).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Ember has decided to repurpose the
::sigil to mean "nested folder invocation" (see emberjs/rfcs#457), this introduces$as a replacement sigil. Ultimately, usage of::will be deprecated by this addon (though that will be in a future commit).Implements part of #202