Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ember-cli-babel to eliminate deprecation #12

Open
jacobq opened this issue Jan 29, 2018 · 3 comments
Open

Upgrade ember-cli-babel to eliminate deprecation #12

jacobq opened this issue Jan 29, 2018 · 3 comments

Comments

@jacobq
Copy link

jacobq commented Jan 29, 2018

Please upgrade ember-cli-babel to a newer (6.11.x) version to eliminate the deprecation warning described here.

This may seem silly because the deprecation warning only affects new versions of Ember that have no need of this polyfill, but because this polyfill is included in ember-inspector it would still be nice.
@jacobq jacobq mentioned this issue Jan 29, 2018
Closed
@rwjblue
Copy link
Owner

rwjblue commented Jan 29, 2018

Totally agreed! I'd happily accept a pull request for this (but I'm not sure when I will have a chance to tackle it myself)...

@jacobq
Copy link
Author

jacobq commented Jan 29, 2018 •
edited
Loading

I may be able to take a stab at it next week. Do you know where I might be able to find a list of the breaking changes I'd need to check? Is it the same as babel?

(Created [WIP] PR #13)

@rwjblue
Copy link
Owner

rwjblue commented Jan 29, 2018

The main breaking change that will matter to this addon is that support for Node < 4 is dropped...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @jacobq