-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ember-cli-babel #13
base: master
Are you sure you want to change the base?
Conversation
jacobq
commented
Jan 29, 2018
•
edited
Loading
edited
CI needs to be updated to use Node 4 (this was the main breaking change in ember-cli-babel@6). |
It looks like I did get a kick out of this line of the output though...oh how time flies: |
Tried running
|
Hold jQuery at 1.11 to avoid version check bug (misses 1.12): https://github.com/emberjs/ember.js/blob/8cc0fca7528c44136fb24be423c1fb51a5fde7c6/packages/ember-views/lib/system/jquery.js#L17
Dang, haha, I got it to pass by locking jQuery at 1.11 since there's an assertion that doesn't realize 1.12 is OK. Feel free to merge or close as you like. Shame on me if I goof around with this any more when I should be doing productive work :) |
Hehe. Thank you for working on it!! |