Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-cli-babel #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jacobq
Copy link

@jacobq jacobq commented Jan 29, 2018

⚠️ Haven't checked to see if this breaks anything yet ⚠️

@rwjblue
Copy link
Owner

rwjblue commented Jan 29, 2018

$ node --version
v0.12.18

CI needs to be updated to use Node 4 (this was the main breaking change in ember-cli-babel@6).

@jacobq
Copy link
Author

jacobq commented Jan 30, 2018

It looks like ember-inspector may simply drop this dependency, and I don't know of any other use cases, so I don't see much point in putting any energy into this. Simple tweaks to .travis.yml to use node 4.x and default npm don't seem to have done the trick (CI build stalled then terminated. Running npm test locally shows lots of No tests were run, please check whether any errors occurred in the page (ember test --server) and ensure that you have a test launcher (e.g. PhantomJS) enabled.).

I did get a kick out of this line of the output though...oh how time flies:
Future versions of Ember CLI will not support v4.8.7. Please update to Node 0.12 or io.js.

@jacobq jacobq changed the title [WIP] Upgrade ember-cli-babel (blindly) [WIP] Upgrade ember-cli-babel Jan 30, 2018
@jacobq
Copy link
Author

jacobq commented Jan 30, 2018

Tried running ember test --server just for fun and am seeing multiple errors in the console:

ember.debug.js:4840 Uncaught EmberError
test-support.js:1001 Uncaught TypeError: $ is not a function
    at test-support.js:1001
    at internalRequire (ember.debug.js:73)
    at internalRequire (ember.debug.js:69)
    at requireModule (ember.debug.js:39)
    at test-support.js:1504
    at test-support.js:1506
loader.js:110 Uncaught Error: Could not find module `ember/resolver` imported from `dummy/app`
    at requireFrom (loader.js:110)
    at reify (loader.js:97)
    at loader.js:140
    at tryFinally (loader.js:21)
    at requireModule (loader.js:139)
    at dummy.js:395

@jacobq
Copy link
Author

jacobq commented Jan 30, 2018

Dang, haha, I got it to pass by locking jQuery at 1.11 since there's an assertion that doesn't realize 1.12 is OK. Feel free to merge or close as you like. Shame on me if I goof around with this any more when I should be doing productive work :)

@rwjblue
Copy link
Owner

rwjblue commented Jan 30, 2018

Hehe. Thank you for working on it!!

@jacobq jacobq changed the title [WIP] Upgrade ember-cli-babel Upgrade ember-cli-babel Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants