Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo Mode improvements #1067

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Todo Mode improvements #1067

merged 9 commits into from
Feb 13, 2023

Conversation

decodism
Copy link
Contributor

@decodism decodism commented Feb 6, 2023

  • Correction of the target of the toggling selector when the settings have the first responder.
  • Disable reflow when mode is disabled.
  • Automatic reflow after changing settings.
  • Ignore sidebar area for actions on the sidebar window.
  • The sidebar window can be resnapped to the sidebar area.
  • Add a shortcut to toggle mode.
  • Save shortcuts to the config.
  • Add a setting for the sidebar side.

@decodism decodism force-pushed the master-2 branch 2 times, most recently from 7b61f81 to 1c1beda Compare February 6, 2023 14:39
@rxhanson
Copy link
Owner

rxhanson commented Feb 7, 2023

Looks good at a quick read through. I'll test it out soon.

One thing to note is that some users did use the reflow with todo mode disabled, so this is going to appear as broken to those users. I've always felt like that's a weird side effect that doesn't quite fit with what Todo mode is trying to achieve, and it is a really small percentage of users, so I'm good with your change.

@decodism
Copy link
Contributor Author

decodism commented Feb 7, 2023

I didn't see the use case and it seemed clearer this way. (relevant xkcd)

@rxhanson rxhanson merged commit baa9ea9 into rxhanson:master Feb 13, 2023
@rxhanson
Copy link
Owner

Thanks! I'm going to adjust the settings tab of the prefs window so it looks a little more tidy before releasing this, though.

@decodism decodism deleted the master-2 branch February 13, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants