-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Todo Mode improvements #1067
Todo Mode improvements #1067
Conversation
decodism
commented
Feb 6, 2023
•
edited
Loading
edited
- Correction of the target of the toggling selector when the settings have the first responder.
- Disable reflow when mode is disabled.
- Automatic reflow after changing settings.
- Ignore sidebar area for actions on the sidebar window.
- The sidebar window can be resnapped to the sidebar area.
- Add a shortcut to toggle mode.
- Save shortcuts to the config.
- Add a setting for the sidebar side.
7b61f81
to
1c1beda
Compare
Looks good at a quick read through. I'll test it out soon. One thing to note is that some users did use the reflow with todo mode disabled, so this is going to appear as broken to those users. I've always felt like that's a weird side effect that doesn't quite fit with what Todo mode is trying to achieve, and it is a really small percentage of users, so I'm good with your change. |
I didn't see the use case and it seemed clearer this way. (relevant xkcd) |
Thanks! I'm going to adjust the settings tab of the prefs window so it looks a little more tidy before releasing this, though. |