Add double-click title bar #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I think what I prefer here is to replace the config in the UI with one checkbox that is for letting Rectangle manage the double click in the title bar to maximize/restore, and let users further configure it via Terminal command if they really want it to do other things. I didn't check but maybe there is an NSUserDefault that we can check to see if they have it enabled in System Settings, and prompt the user to disable it if it is enabled when a user checks this one checkbox in Rectangle. |
|
Done. You may want to tweak it further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1097. The detection of the title bar is a bit worse than the one of the system.