Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Simplified Chinese localization #1105

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

Jerry23011
Copy link
Contributor

@Jerry23011 Jerry23011 commented Mar 10, 2023

Changes

  • Add new translations
  • Adjust spacing (according to conventions, there should be a space between English letters and Chinese characters)

@rxhanson
Copy link
Owner

Thanks! Since macOS < 13 is still supported, the Preferences strings are still valid, and any instances in Ventura where Preferences is still displayed in the app, I need to fix it in the code rather than here in the localization file.

@Jerry23011
Copy link
Contributor Author

Jerry23011 commented Mar 10, 2023

Thanks! Since macOS < 13 is still supported, the Preferences strings are still valid, and any instances in Ventura where Preferences is still displayed in the app, I need to fix it in the code rather than here in the localization file.

Got it, so I'll just revert that particular change and wait for the change in code :)

@rxhanson rxhanson merged commit 2bd208e into rxhanson:master Mar 10, 2023
@rxhanson
Copy link
Owner

Excellent, thanks!

@Jerry23011 Jerry23011 deleted the sc-3-10 branch March 10, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants