-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Lithuanian language translation #1139
Conversation
If I've missed something, did incorrectly or there is any other feedback please let me know. |
Rectangle/lt.lproj/Main.strings
Outdated
"YEy-JH-Tfz.title" = "Rasti ir pakeisti…"; | ||
|
||
/* Class = "NSMenuItem"; title = "\tDefault"; ObjectID = "YGs-j5-SAR"; */ | ||
"YGs-j5-SAR.title" = "\tПо умолчанию"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double-checking if this is correct since it's Cyrillic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry. Just found out I missed translations in 2 places. Here is the regex to use to find if there are any Cyrillic characters left: [\u0400-\u04FF]. Committing an update shortly.
Thanks for contributing! There's just one comment from reading through it. Also, the file has to be registered in Xcode. I can do that if you don't know how. |
I will try add the file from Xcode when I return from work. Also, I've noticed that other translation contributions have included translations for RectangleLauncher/[language].lproj/Main.strings. Would you like me to work on that as well? Please let me know if this is something you'd also like me to complete. |
…& RectangleLauncher Lithuanian translation to localisations via xcode
@rxhanson I've added RectangleLauncher translations and included both localizations through Xcode. However, could you please take a look at the Main.storyboard file? I'm not certain why the heights and widths have changed in some of the elements. If they are incorrect, I'd appreciate it if you could fix them. I don't believe I've made any mistakes with any of the items, and it's possible that the newer Xcode made these changes by default. But not sure... |
Rectangle/lt.lproj/Main.strings
Outdated
|
||
"Use frontmost.app as Todo App" = "Naudoti pirmame plane esantį langą kaip Todo programą"; | ||
"Enable Todo Mode" = "Įjungti Todo programos režimą"; | ||
"Perdėlioti Todo" = "Atnaujinti Todo lango padėtį"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a few of the English keys got translated into Lithuanian, here and at the end. Would you mind making sure that the correct English keys are in? I'd give it a go myself, but sometimes these can move around between the different translation files and it's probably easier for you to check.
Thanks for the follow up. The launcher translation wasn't necessary (sorry, I need to update documentation around this and/or rip them all out). Xcode tends to make those size adjustments from time to time, and I'll make sure things look fine after a merge. |
@firebotQL Just following up, in case you didn't catch the comment after your latest revision:
No rush on a reply, I don't have a release planned for a little while. |
Yes, sorry. Did mean to look into it yesterday, but didn't have chance. Will try to address your comments today. |
@rxhanson tagging you here as pushed the change yesterday. let me know if anything else is amiss. |
Thanks! |
Added Lithuanian localisation.