Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation to Norwegian (Nynorsk)/NN, added untranslated files for a possible Norwegian (bokmål)/NB translation #1252

Merged
merged 9 commits into from
Sep 16, 2023

Conversation

snomos
Copy link
Contributor

@snomos snomos commented Sep 4, 2023

Didn't manage to build, so haven't been able to test how well the translations fit the available space in the UI. Would it be possible to get a prerelease build that I could test?

@rxhanson
Copy link
Owner

rxhanson commented Sep 4, 2023

Thanks, I'll update the localizations in Xcode and let you know when there's a build to look at.

@rxhanson
Copy link
Owner

Sorry for taking so long to get back to this. Here's the link to the build that was generated:
https://github.com/rxhanson/Rectangle/actions/runs/6162760673?pr=1252

Note that it's not signed, so you'll have to bypass gatekeeper to install it.

Let me know if you need any assistance here.

@snomos
Copy link
Contributor Author

snomos commented Sep 13, 2023

Thanks for the build, I got pass gatekeeper.

Unfortunately I have the same issue that I got when I tried building it myself: it starts, and then present me with the dialog that says I need to authorise Rectangle in System preferences. I do, and restart Rectangle, but whatever I do, it can't come pass this point - even if authorised, it still tells me to authorise. The good news is that the dialog is in Norwegian, the bad thing is I can't actually run the app beyond this point.

This does not happen with the signed binary.

I assume there is a settings file or something that has been corrupted or something, any advice on how to clean up would be greatly appreciated.

@rxhanson
Copy link
Owner

Sure, so what's going on here is that the accessibility permissions are associated with the "fingerprint" of the signed app and not the unsigned app.

In the case of Xcode, if you leave it configured without a developer id then I think it will require you to "reset" the accessibility permissions every time you build and run the app. I need to note this in the Readme.

You can reset the accessibility permissions by the following:

  1. Quit Rectangle.
  2. Go to System Settings -> Privacy & Security -> Accessibility
  3. Disable Rectangle with the toggle
  4. Remove Rectangle with the minus button
  5. Relaunch the unsigned version and add the accessibility permissions as prompted.

Thanks again, sorry this is an annoying obstacle.

@snomos
Copy link
Contributor Author

snomos commented Sep 14, 2023

Thanks a lot for the help, removing Rectangle from the preferences with the minus button did the trick - hadn't tried that.

@snomos
Copy link
Contributor Author

snomos commented Sep 14, 2023

Both NN and NB localisations done now, feel free to include them in the next release or whenever suits you.

Thanks for the help!

@rxhanson rxhanson merged commit 9f1fd3f into rxhanson:master Sep 16, 2023
@rxhanson
Copy link
Owner

Thanks! This will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants