-
Notifications
You must be signed in to change notification settings - Fork 197
[Android&iOS] Support language problem fix #33
base: master
Are you sure you want to change the base?
Conversation
+@ It was confirmed that only a few languages were hard-coded to support. So, other than the four languages that were declared directly, i immediately created and changed them to deliver. |
@rxlabz |
Hey @UnRyongPark - thanks for PR. Could you describe a bit more on what's been fixed and how to reproduce issue on current master branch? I've been using the plugin for speech recognition for Polish language and it works like a charm - no issue detected. You mentioned that only Korean and English works normally for you? |
@vintage Hello :D that is two problem.
|
I didn't yet tested the speech recognition on iOS in my app - will do that probably later this month, so will back on this one a bit later on if that's a not a problem :) As for Android to detect Polish language I've used following code: _speech = SpeechRecognition();
_speech.setRecognitionResultHandler((String text) {
print("Recognized text is $text");
});
_speech.setRecognitionCompleteHandler((_) {
Future.delayed(Duration(seconds: 1)).then((_) {
_speech.listen(locale: 'pl_PL');
});
});
_speech.listen(locale: 'pl_PL'); And it properly detects the language and accent. Can you provide what locale did you pass to the |
@vintage oh! cool! ps. A little worrisome is to split the locale code and use only two.(SpeechRecognitionPlugin.java, line 91~92) |
Thanks for your contribution @UnRyongPark |
@vintage @ngoan98tv Thanks :D I think there's a better way. I will be updating the PR further in the near future. |
Any chance of this being merged soon? I want to use Japanese and there aren't many options for plugins. If this won't be merged, I'll need to do a custom build for myself soon. |
Nice to find your great plug-in.
If you are not satisfied with the code that I modified, please request modification:)
I tested it on my cell phone using your plug-in and found that no input other than Korean and English was returned normally.
After debugging the code, After changing the parameter to String, it was confirmed to be working properly.
(SpeechRecognitionPlugin.java:67-68)
Once you've seen it working properly in the example app, I wonder why you've added Locale. Did I use it wrong?