Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to override default parameters #442

Closed
wants to merge 1 commit into from

Conversation

CAB233
Copy link
Contributor

@CAB233 CAB233 commented Jul 31, 2024

I found that the default variables couldn't be overridden:

Run ./r2-upload-action
  with:
    r2-account-id: ***
    r2-access-key-id: ***
    r2-secret-access-key: ***
    r2-bucket: ***
    source-dir: /home/runner/work/myAUR/myAUR
    destination-dir: archlinux/test
    keep-***-fresh: true
    output-***-url: true
    multipart-size: 100
    max-retries: 5
    multipart-concurrent: true
/usr/bin/docker exec  b8410f562f004919b3c2ff11fa1ed38eb158f479ec5521b2165a0015abbaf038 sh -c "cat /etc/*release | grep ^ID"
debug: Config.keepFileFresh: false

Secondly, I found that other variables with default values seem to have the same problem, such as multipart-concurrentand output-file-url. I tried to fix them the same way but it doesn't seem to work, you may need to reconfirm it.

@CAB233 CAB233 requested a review from ryand56 as a code owner July 31, 2024 12:55
@ryand56 ryand56 changed the base branch from master to develop July 31, 2024 20:52
@ryand56
Copy link
Owner

ryand56 commented Jul 31, 2024

I can't reproduce this on my end, but the keep file fresh typo, I'll change
Fixed typo in b7dbb2a

@ryand56 ryand56 added the invalid Unreasonable/impossible to fix label Jul 31, 2024
@ryand56 ryand56 closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Unreasonable/impossible to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants