Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #34

Merged
merged 8 commits into from
Mar 28, 2013
Merged

Refactoring #34

merged 8 commits into from
Mar 28, 2013

Conversation

ryandotsmith
Copy link
Owner

A couple of things are going on here:

main

This is the http receiver. As such, I moved most of the receiving logic out into a receiving package. I added a test for the receiver to boot!

bucket

After explaining l2met internals to several folks, I found myself using a set of terms that seemed to resonate. The changes I made to the bucket code reflect these new terms and models. There now exists:

  • bucket.Id
  • bucket.Bucket

store

One of the great things to come out of these changes is that redis logic is isolated to store/redis_store. Also, the store is now an interface. Consequently, I implemented a MemStore that can be used in testing.

tests

I added receiver/receiver_test.go which not only tests the receiving path. But also highlights to how to the new code paths.

data flow

I have taken great care in not changing the how data flows in & out of l2met. I wanted to preserve all of the performance tuning that we have been doing.

@ryandotsmith
Copy link
Owner Author

I was able to test these changes out on some staging and production instances and things look great!

ryandotsmith pushed a commit that referenced this pull request Mar 28, 2013
@ryandotsmith ryandotsmith merged commit f6ca916 into master Mar 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant