Adding float support, DecodeOwned array blanket implementation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
changed the title
ryan-summers
commented
Nov 21, 2022
| type Output = [<T as DecodeOwned>::Output; N]; | ||
|
|
||
| fn decode_owned(buff: &[u8]) -> Result<(Self::Output, usize), Self::Error> { | ||
| let mut data: [T; N] = [T::default(); N]; |
There was a problem hiding this comment.
I'd really love to use MaybeUninit for this, but I couldn't get it to work. Making an [MaybeUninit::uninit(); N] requires a T: Copy, and then attempting to core::mem::transmute() the MaybeUninit into a [T; N] results in a compiler error due to sizing issues for some reason, which appears to be a limitation of rust.
There was a problem hiding this comment.
yeeah, i fell down this rabbit hole too 😅 seems like a good enough approach for now, which can be removed once array::try_from_fn lands anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1 by adding f32/f64 support for Enc/Dec traits.