Making a task which rebuilds test coverage for Node #146
Conversation
| @@ -1,107 +0,0 @@ | |||
| TN: | |||
| SF:/home/ryanluker/dev/vscode-coverage-gutters/example/node/test.js | |||
There was a problem hiding this comment.
These absolute paths are wrong on every machine but @ryanluker's, so we should not rely on them.
There was a problem hiding this comment.
these paths are fine in the new way we do path comparison (now that top score is dead). it also has the benefit of the build machine not needed to be able to generate xml for node, python, php, etc.
|
|
||
| this.filterCoverage(topSection, coverageLines); | ||
| this.setDecorationsForEditor(textEditor, coverageLines); | ||
| if (section) { |
There was a problem hiding this comment.
@ryanluker this can cause the wrong score, etc. to carry over because it doesn't flush properly. noticed with the Python tests with the score filtering thing.
There was a problem hiding this comment.
good catch, fixed this in my other PR #152
|
@brandongk60 closing this as we are doing away with the top score logic but replaced it with relative comparison logic. |
hard-coding the coverage file in the repo is non-indicative as the path is wrong (i.e. has ryanluker hard-coded).
The Python project matters less because the
cov.xmlfile has relative paths anyways.