-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for dotnet #357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flatrick Thanks for the PR!
The only suggestion that probably should be done before merging, is around promoting this in the readme as well.
https://github.com/ryanluker/vscode-coverage-gutters/blob/master/README.md#officially-supported-languages-backed-by-tests-ran-nightly
Otherwise, looks great, and thanks for the contibution!
## Run the tests and generate the coverage report | ||
|
||
Open the new icon for **Testing** _(.NET Core Test Explorer)_ and run the tests. | ||
When you open any source-files under `src/`, Coverage Gutter will show code coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the readme and the example project!
example/dotnet/src/Program.cs
Outdated
@@ -0,0 +1,2 @@ | |||
// See https://aka.ms/new-console-template for more information | |||
Console.WriteLine("Hello, World!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for this PR, but we could also consider adding this project to the integration tests so that way we know the extension works with this version of dotnet.
https://github.com/ryanluker/vscode-coverage-gutters/blob/master/test/extension.test.ts#L183-L204
example/dotnet/test/UnitTest1.cs
Outdated
{ | ||
|
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned above, we could also consider fleshing this out and adding in a dotnet test to the integration suite.
@ryanluker I've provided a new commit that I think addresses all of your wishes above and added some instructions to run the tests/create the coverage data using a vscode task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flatrick Excellent looks great, thanks for the contribution!
@flatrick added the example to the root readme here b0432d7 it should go out into the wild (https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters) sometime this week! |
Written some instructions for how to get started with Coverage Gutters and dotnet (core/5+), and an example project done using the very same steps.