Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for dotnet #357

Merged
merged 2 commits into from
Feb 27, 2022
Merged

Add instructions for dotnet #357

merged 2 commits into from
Feb 27, 2022

Conversation

flatrick
Copy link
Contributor

Written some instructions for how to get started with Coverage Gutters and dotnet (core/5+), and an example project done using the very same steps.

Copy link
Owner

@ryanluker ryanluker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flatrick Thanks for the PR!

The only suggestion that probably should be done before merging, is around promoting this in the readme as well.
https://github.com/ryanluker/vscode-coverage-gutters/blob/master/README.md#officially-supported-languages-backed-by-tests-ran-nightly

Otherwise, looks great, and thanks for the contibution!

## Run the tests and generate the coverage report

Open the new icon for **Testing** _(.NET Core Test Explorer)_ and run the tests.
When you open any source-files under `src/`, Coverage Gutter will show code coverage.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the readme and the example project!

@@ -0,0 +1,2 @@
// See https://aka.ms/new-console-template for more information
Console.WriteLine("Hello, World!");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for this PR, but we could also consider adding this project to the integration tests so that way we know the extension works with this version of dotnet.
https://github.com/ryanluker/vscode-coverage-gutters/blob/master/test/extension.test.ts#L183-L204

{

}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, we could also consider fleshing this out and adding in a dotnet test to the integration suite.

@flatrick
Copy link
Contributor Author

@ryanluker I've provided a new commit that I think addresses all of your wishes above and added some instructions to run the tests/create the coverage data using a vscode task

Copy link
Owner

@ryanluker ryanluker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flatrick Excellent looks great, thanks for the contribution!

@ryanluker ryanluker merged commit 0a2f031 into ryanluker:master Feb 27, 2022
@ryanluker ryanluker added this to the 2.10.0 milestone Feb 27, 2022
@ryanluker
Copy link
Owner

@flatrick added the example to the root readme here b0432d7 it should go out into the wild (https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters) sometime this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants