Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor fix #386

Merged
merged 2 commits into from
May 7, 2018
Merged

Cursor fix #386

merged 2 commits into from
May 7, 2018

Conversation

eoso
Copy link

@eoso eoso commented Aug 6, 2015

I fixed the cursor function to grab next pages of results when using the search function or one of the timeline functions. (Copy of previous pull request in which I had made a mistake with git branches.)

@michaelhelmick
Copy link
Collaborator

Was there an issue out for this PR?

@michaelhelmick
Copy link
Collaborator

Hi @eoso. Just re-uping

#386 (comment)

@eoso
Copy link
Author

eoso commented Sep 13, 2015

Hey, thanks for getting my attention. I got busy.

I noticed that when iterator mode uses since_ids, the cursor generator would start repeatedly yielding the same tweet once it reached the end of it's initial block of tweets.

A few people had similar problems: #365, #325.

I noticed that someone had written a fix (which also included a sleep function) over a year ago but wasn't pulled: #332

I can post some code later as well, if that's helpful, but don't have the time to get it setup at the moment.

@ababino
Copy link

ababino commented Jul 7, 2016

Dear all,
I had a problem with cursor and get_user_timeline but the fix by @eoso solved it! Please, if it is possible, mearge the fix. If there is anything I can help with please let me know.
Bests

@AmauryCarrade
Copy link

Same here, this PR fixed the cursors bug with get_user_timeline for me.

@dannguyen
Copy link

I was writing a tutorial on how to use Twython for collecting tweets, particularly, paginating through a user's available timeline and was wondering if there was an estimated ETA for merging in this pull request into a new release?

@michaelhelmick
Copy link
Collaborator

Re-pinging @eoso?

@decklord
Copy link

decklord commented May 4, 2018

Can you merge this?

@michaelhelmick
Copy link
Collaborator

By popular demand, I will merge this despite tests. I'll try and do a release soon.

@michaelhelmick michaelhelmick merged commit 62e45e9 into ryanmcgrath:master May 7, 2018
@michaelhelmick
Copy link
Collaborator

Twython 3.7.0 is now available on PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants