Fix arity check for keyword arguments #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanong
reviewed
Oct 3, 2018
test/support/features.rb
Outdated
| Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.0.0") | ||
| end | ||
|
|
||
| def required_keyword_args? |
There was a problem hiding this comment.
I would be willing to drop ruby 2.0.0 support to reduce code complexity
|
looks like there are some failures on jruby. If you don't want to fix those that is fine I'll try to fix it |
Previously keyword arguments were ignored, which prevented them from being passed in. This at least allows them to be passed in by treating them as a single optional or required argument. However, it doesn't yet check that a hash is passed in for the keyword arguments or that the hash has the expected keys.
dylanahsmith
force-pushed
the
kwarg-arity-check
branch
from
2c40c59 to
de9e647
Compare
dylanahsmith
force-pushed
the
kwarg-arity-check
branch
from
de9e647 to
2eae13e
Compare
|
For some reason I am not able to reproduce the jruby failures locally. However, it looks like the failures isn't happening after rebasing on top of #11 |
|
ruby 2.0 support has been dropped to simplify the code and tests are passing. Are there any other concerns? |
|
Thanks for the contribution I'll make a push now or when I get home |
|
@dylanahsmith pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Previously keyword arguments were ignored, which prevented them from being passed in. This at least allows them to be passed in by treating them as a single optional or required argument. However, the code doesn't yet check that a hash is passed in for the keyword arguments or that the hash has the expected keys.