Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 16 Portals #94

Closed
Fer0x opened this issue Dec 21, 2017 · 2 comments
Closed

React 16 Portals #94

Fer0x opened this issue Dec 21, 2017 · 2 comments

Comments

@Fer0x
Copy link
Contributor

Fer0x commented Dec 21, 2017 •
edited
Loading

Since Portals were introduced in React 16, are there any benefits to use react-frame-component over ReactDOM.createPortal?
For example: https://gist.github.com/robertgonzales/b1966af8d2a428a8299663b92fb2fe03
@TuckerWhitehouse
Copy link
Contributor

I have an open pull request (see #92 & #93) for migrating this library to use ReactDOM.createPortal. I think the benefit is in not having to recreate the same boilerplate and the additional hooks a library like this provides (such as the initalContent and mountTarget).

@Fer0x
Copy link
Contributor Author

Fer0x commented May 15, 2018 •
edited
Loading

Resolved in #93, #103

@Fer0x Fer0x closed this as completed May 15, 2018
@erquhart erquhart mentioned this issue May 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fer0x @TuckerWhitehouse