Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmounting the mount target may crash the app if the node doesn't exist #87

Closed
erquhart opened this issue Nov 6, 2017 · 1 comment
Closed

Comments

@erquhart
Copy link
Contributor

erquhart commented Nov 6, 2017

First off, thanks for this lib!! We've been using it since the beginning in Netlify CMS, really glad it's here :)

So we ran into an issue in the latest version of Firefox Stable, 56.0.2, where attempting to unmount the mount target in Frame's componentWillUnmount handler errors out because the target isn't there. I haven't traced this all the way back, but it seems like some kind of race condition.

I also have a feeling that this isn't a new bug, but that perhaps it was just less obvious before React 16 made every error a showstopper, and was maybe even recoverable when the parent of Frame updated after a failure.

Anyway, just a heads up, PR forthcoming. If it's at all possible to get a quick release I'd be super grateful. Thanks!!

@erquhart erquhart changed the title Unmounting the mounting target may crash the app if the node doesn't exist Unmounting the mount target may crash the app if the node doesn't exist Nov 6, 2017
erquhart added a commit to erquhart/react-frame-component that referenced this issue Nov 6, 2017
@ibash ibash closed this as completed in #88 Nov 16, 2017
@erquhart
Copy link
Contributor Author

@ryanseddon this was regressed by #94 in 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant