fix: fix _agenix_generation being (very shortly) empty if readlink fails #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently trying to improve agenix (mostly for myself) and realized that
_agenix_generation
never gets set properly.When
basename
wrapsreadlink
in quotes, the or condition that would return0
never gets executed becausebasename ""
doesn't fail.This isn't really a problem atm because
(( ++_agenix_generation ))
will treat empty variables as if they were 0, but might lead to some issues in the future.I moved the condition to the
readlink
subshell, which shouldn't cause any issues sincebasename "0"
will just return0
.I also wrapped
${cfg.secretsDir}
in quotes in case someone sets it to a path with spaces.