Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report when files are missing instead of reporting no issue #184

Closed
ptalbert opened this issue Oct 5, 2015 · 2 comments
Closed

Report when files are missing instead of reporting no issue #184

ptalbert opened this issue Oct 5, 2015 · 2 comments

Comments

@ptalbert
Copy link
Collaborator

ptalbert commented Oct 5, 2015

xsos --ethtool will report [None] for Interface Errors if the ethtool_-S_{$DEVICE} files are missing. This is seen on some older RHEL 5 series SOS Reports.

Ideally, xsos would report [No available stats files] or some such output instead of reporting there are no errors as this is misleading.

@ryran
Copy link
Owner

ryran commented Oct 6, 2015

Ahh yes I forgot about this. Good call.

On Mon, Oct 5, 2015, 14:47 ptalbert [email protected] wrote:

xsos --ethtool will report [None] for Interface Errors if the
ethtool_-S_{$DEVICE} files are missing. This is seen on some older RHEL 5
series SOS Reports.

Ideally, xsos would report [No available stats files] or some such output
instead of reporting there are no errors as this is misleading.


Reply to this email directly or view it on GitHub
#184.

@ryran
Copy link
Owner

ryran commented Dec 31, 2015

Fixed in forthcoming 0.7.7.

$ xsos -e .
ETHTOOL
  Interface Status:
    bond0                link=up 10000Mb/s full (autoneg=N)  rx ring UNKNOWN    drv bonding v3.7.1 / fw 2
    bond1                link=up 1000Mb/s full (autoneg=N)   rx ring UNKNOWN    drv bonding v3.7.1 / fw 2
    eth0   0000:03:00.0  link=DOWN                           rx ring 200/2047   drv tg3 v3.137 / fw 5719-v1.38 NCSI v1.2.37.0
    eth1   0000:03:00.1  link=DOWN                           rx ring 200/2047   drv tg3 v3.137 / fw 5719-v1.38 NCSI v1.2.37.0
    eth2   0000:03:00.2  link=up 1000Mb/s full (autoneg=Y)   rx ring 200/2047   drv tg3 v3.137 / fw 5719-v1.38 NCSI v1.2.37.0
    eth3   0000:03:00.3  link=up 1000Mb/s full (autoneg=Y)   rx ring 200/2047   drv tg3 v3.137 / fw 5719-v1.38 NCSI v1.2.37.0
    eth4   0000:04:00.0  link=up 10000Mb/s full (autoneg=N)  rx ring 1024/1024  drv be2net v10.4r / fw 10.2.340.19
    eth5   0000:04:00.1  link=up 10000Mb/s full (autoneg=N)  rx ring 1024/1024  drv be2net v10.4r / fw 10.2.340.19
  Interface Errors:
    eth4  Missing ethtool_-S file
    - - - - - - - - - - - - - - - - - - -
    eth5  rx_udp_checksum_errs: 1

@ryran ryran closed this as completed in b3b5fcc Dec 31, 2015
ryran added a commit that referenced this issue Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants