Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bios module improperly calculates "system max capacity" for memory #205

Closed
ryran opened this issue Sep 9, 2016 · 2 comments
Closed

bios module improperly calculates "system max capacity" for memory #205

ryran opened this issue Sep 9, 2016 · 2 comments
Assignees
@ryran

Comments

@ryran
Copy link
Owner

ryran commented Sep 9, 2016 •
edited
Loading

YEP!

I always assumed discrepancies were due to crappy dmi tables but it turns out I was parsing it wrong all along! I.e., many machines show Maximum Capacity field for each memory array, so we need to sum them together. Easy fix.
@ryran ryran self-assigned this Sep 9, 2016
@ryran
Copy link
Owner Author

ryran commented Sep 9, 2016

Also didn't account for some machines reporting "kB" and some reporting "MB" and some reporting "GB".

ryran added a commit that referenced this issue Sep 9, 2016
@ryran
v0.7.10: fix for dmidecode-parsing issues #203 and #205
cab2d74
@ryran ryran mentioned this issue Sep 9, 2016
Merged
ryran added a commit that referenced this issue Sep 9, 2016
@ryran
Merge pull request #206 from ryran/issue203-dmidecode
e8d6dee 
v0.7.10: fix for dmidecode-parsing issues #203 and #205
@ryran
Copy link
Owner Author

ryran commented Sep 9, 2016

DONE AND DONE. See PR for screenshot.

@ryran ryran closed this as completed Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryran ryran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryran