Fixed issue with dot separator when decimalScale is set to zero #375

s-yadav · Feb 20, 2020 · c327ebe · c327ebe
1 parent 97ccf23
commit c327ebe
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/number_format.js b/src/number_format.js
@@ -615,7 +615,8 @@ class NumberFormat extends React.Component {
 
     /** Check for any allowed decimal separator is added in the numeric format and replace it with decimal separator */
     if (!format && start === end && allowedDecimalSeparators.indexOf(value[selectionStart]) !== -1  ) {
-      return value.substr(0, selectionStart) + decimalSeparator + value.substr(selectionStart + 1, value.length);
+      const separator = this.props.decimalScale === 0 ? '' : decimalSeparator;
+      return value.substr(0, selectionStart) + separator + value.substr(selectionStart + 1, value.length);
     }
 
     /* don't do anyhting if something got added,

diff --git a/test/library/input_numeric_format.spec.js b/test/library/input_numeric_format.spec.js
@@ -544,6 +544,17 @@ describe('Test NumberFormat as input with numeric format options', () => {
     expect(wrapper.state().value).toEqual('$000012,345,678');
   });
 
+  //Issue #375
+  it('should give correct formatted value when pasting the dot symbol with decimal scale is set to zero, issue #375', () => {
+    const wrapper = shallow(<NumberFormat
+      value={4200}
+      thousandSeparator={true}
+      decimalScale={0}
+    />);
+    simulateKeyInput(wrapper.find('input'), '.', 2, 2);
+    expect(wrapper.state().value).toEqual('4,200');
+  });
+
   describe('Test thousand group style', () => {
     it('should format on english style thousand grouping', () => {
       const wrapper = shallow(<NumberFormat thousandSeparator={true} value={12345678}/>);