Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with server-side-rendering (SSR) #481

Closed
rj-david opened this issue Jan 5, 2021 · 10 comments · Fixed by #560
Closed

Issue with server-side-rendering (SSR) #481

rj-david opened this issue Jan 5, 2021 · 10 comments · Fixed by #560
Labels

Comments

@rj-david
Copy link

rj-david commented Jan 5, 2021

Seems like the changes in version 4.4.3 introduced this error which makes this package not compatible with SSR

ReferenceError: navigator is not defined
    at addInputMode (/project/node_modules/react-number-format/lib/utils.js:214:22)
    at NumberFormat.render (/project/node_modules/react-number-format/lib/number_format.js:1007:47)
@linhtv97
Copy link

linhtv97 commented Jan 5, 2021

Me too

@AbodyAmer
Copy link

Me too on version 4.3.0

@gustavocarvalho07
Copy link

Same here!

@rj-david
Copy link
Author

rj-david commented Jan 6, 2021

@s-yadav hope you can check

@neosa
Copy link

neosa commented Jan 6, 2021

Wtf? same problem

@s-yadav
Copy link
Owner

s-yadav commented Jan 6, 2021

Shit. Will fix it soon.

@s-yadav s-yadav added the bug label Jan 6, 2021
@s-yadav s-yadav closed this as completed in 8af3795 Jan 6, 2021
@s-yadav
Copy link
Owner

s-yadav commented Jan 6, 2021

@rj-david @gustavocarvalho07 Fixed on 4.4.4

Let me know if the issue still persists.

@rj-david
Copy link
Author

rj-david commented Jan 7, 2021

Confirming the fix. Thanks @s-yadav

@gustavocarvalho07
Copy link

It is working now! Thank you so much, @s-yadav !!!

luizeboli added a commit to ufersa/plataforma-sabia that referenced this issue Mar 9, 2021
* [SERVICES] Homepage  (#830)

* refactor(web): change register technology button title

* refactor(web): rewrite hero component to match figma

* refactor(web): improve code readability and adjust index for idea bank

* feat(web): add service algolia index to provider and config

* feat(web): add new props to herosearch component

They will be used to switch between services and technologies when doing searches

* feat(web): add tabs into hero search to choose between services and technologies

* style(web): adjust hero height

* style(web): refactor home section title component to match new figma styles

* refactor(web): adjust section title and remove recent technologies

* feat(web): add white color variant to likes button

* reverts(web): add searchplaceholder back as its in use by search page

* refactor(web): rewrite homepage structure and cards component

* feat(web): add services cards to home

* refactor(web): add imageLabel to card component and adjust how links are managed

* style(web): improve card badge style

* build(web): add domains to next image component

* style(web): adjust rectangular button green variant to match figma

* feat(web): add type prop to likes so we can handle many solutions when checking bookmarks

* refactor(web): rewrite card component to multi solutions format

* feat(web): add services and technologies to home page

* style(web): change bookmark message if not signed

* feat(web): add new rectangular button variant to use background images

* refactor(web): adjust service card url

* refactor(web): add custom padding prop to layout component

* feat(web): add links to resources in home page

* style(web): remove link from service as theres no slug/page

* feat(web): handle bookmarking services

* fix(web): change technology details page component to use right solutionssection

* test(web): fix tests breaking after improving some details on homepage

* style(web): adjust homepage margin from buttons and technologies

* chore(web): add new variant to proptypes

* style(web): adjust card style

* test(web): update snapshot

* test(web): adjust cypress tests to cover new technology scenarios

* test(web): add cypress coverage for services homepage

* test(web): remove only from it statement

* chore: remove open command from package.json

* [SERVICES] Shopping cart (#839)

* style(web): add margin when theres svg in button

* refactor(web): rewrite typography common component props

* feat(Web): add shopping cart page structure

* feat(web): add fullwidth variant to button

* feat(web): add shopping cart page structure

* fix(web): adjust prop types from technology card

* feat(web): add option to return currency formated without sign

* feat(web): add measure unit enum

* feat(web): add helper to return measure unit label

* feat(web): add new prop to empty screen component and let message be an element

* refactor(web): fix target prop

* feat(web): forward refs to rectangular button/'

* feat(web): add quantity field component

Sadly it isnt integrated with RHF. It'd be nice to have it, but for now it's unnecessary

* feat(web): add shopping cart context logic

* feat(web): add shopping cart icon to header

* fix(web): adjust technology card markup

* feat(web): add service to cart when clicking in service acrd

* refactor(web): change cartitem to show right from cart context

* feat(web): integrate shopping cart page with context

* style(web): improve shopping cart badge

* fix(web): use next link to wrap search button

* feat(web): do not let user complete order if not signed in

* fix(web): adjust component forwardref behavior

* refactor(web): use only one Header for the whole app

* fix(web): handle with scrolling offset due fixed header when coming from other pages

* feat(web) add user links to header and hamburguer menu and handle when showing or not

* refactor(web): add home links to header

* feat(web): save and get shopping-cart items from cookies

* style(web): adjust search input behavior

* style(web): change margin from sections title

* refactor(web): remove contact-us page as it has been moved to about landingpage

* fix(web): adjust uncompleted profile message

* fix(web): update user object if user prop changed in provider

This is needed so user's updated by _app

* fix(web): use optional chaining to safeguard code

* feat(web): add submit for services

* refactor(web): add default likes prop

* feat(web): send comments with service order

* style(web): adjust responsive layour for shopping cart items

* refactor(web): organize header shopping cart component

* fix(web): use right thumbnail object in cartitem

* test(web): update snapshot

* refactor(web): reuse code on header to avoid duplicating ternaries

* refactor(web): rename action

* refactor(web): improve readability

* style(web): remove unused proptypes

* refactor(web): improve prevention of bugs

* feat(web): add a helper to get if env is client-side

* feat(web): do not allow resize in textfield

* feat(web): reset cart after successfull submit

* fix(web): use resetIdCounter for react tabs ssr

* refactor(web): rename service for right convention

* style(Web): improve code readability

* refactor(web): update how cart load items

Its better if we replace

* feat(web): add method in shopping cart provider for check if items has updates

This prevents solutions owner to change price and it didn't update cart item

* feat(web): delete items from cart if its deleted from api

* [SERVICES] Register page (#851)

* feat(web): add new solution page structure

* style(web): add zindex to rectangular button so the background doesnt overflow before pseudo

* feat(web): add color prop to title component

* feat(web): add new solution page content

* style(web): normalize new solution page name

* feat(web): add fullwidth prop to rectangular button

* fix(web): allow textfield to be reseted by RHF

* feat(api): add institution filter to getMe

* feat(web): get user institution on getMe

* feat(web): add instanceId to selectfield so it handles SSR

* feat(web): add resize prop to TextField

* feat(web): add ckeditor modal

* feat(web): add service solution options

* feat(web): add service to get terms

* feat(web): add html view component to act like an input

* refactor(web): rewrite CKEditor component to it works with and without RHF Controller

This is needed because when you deletes the Controller it resets the form value. We don't want this behavior because service registering has an input that should open inside a Modal

* feat(web): add new props to CKEditor modal

* style(web): adjust ckeditor link popup

* feat(web): add service for creating a service solution

* feat(web): add props to ckeditor modal

* feat(web): add service for deleting a service solution

* refactor(web): return empty array

* feat(api): return thumbnail when creating a service

* feat(web): add new service page

* chore(api): update package lock

* test(api): fix service test

* test(web): update snapshots

* test(e2e): fix cypress login test

* refactor(web): add search link to header

* style(web): add gradient to search header page

* refactor(web): export radio from form

* fix(web): adjust service index name

* feat(web): add styles options to radio component

* refactor(web): change results translation text

* style(web): adjust algolia components to match new figma search page

* feat(api): add technology type to algolia index

* chore(web): add platform hosts to next images domains

* refactor(api): convert technology type when sending to algolia

* feat(web): add translations for search page

* feat(web): add prop to use transformItems in refinementlist

* refactor(api): remove technology category from algolia index

* feat(api): add is_seller to algolia index as forSale property

* refactor(web): use new type from algolia

* feat(web): add translations for filtering for sale technologies

* feat(api): add institution initials to algolia index

* feat(web): add translations for filtering for institutions

* refactor(api): handle when institution is not defined in algolia

* feat(api): handle service type in algolia index

* fix(api): get institution initials from right prop

* feat(api): quick and dirty fix to config service algolia index

* style(web): add pointer cursor to toggle refinement component

* feat(web): add structure for search page regarding technologies and services filters

* feat(web): use new search structure to render filters and results

* refactor(web): get type from enum

* refactor(web): adjust search technology hit card to match figma

* feat(web): create common card style for search page

* feat(web): add new service card for search page

* feat(web): add search cards in a single frame and add service to cart feature

* fix(web): send body to request on apiDelete

* refactor(web): write handler in a semantic way

* fix(api): return serviceBookmarks on getMe

* refactor(web): do not render measure unit if its other

* style(web): improve responsive layout for cards

* feat(web): update user context when handling solutions like

* fix(web): use right property from user

* feat(api): add service title as a filter attribute

* style(web): remove unnecessary comment

* refactor(web): adjut proptypes

* feat(web): add react tabs reset counter on search page

* feat(web): add resetIdCounter to document so don't need to worry about tabs anymore

* refactor(web): remove reset id counter from search page as its in document

* feat(web): receive indexName in algolia provider

* feat(web): pass indexName to algolia provider

* feat(web): handle query params filtering

* fix(e2e): remove only statement

* test(e2e): create e2e file for services

* feat(api): update algolia indexes when bookmarkin a solution

Added an option to Algolia methods to update an Object instead of redefine

* test(web): update tests

* test(api): update service tests to reflect algolia changes

* test(api): update technology tests to reflect algolia changes

* test(api): update user functional tests

* test(e2e): add test for rendering and bookmarking a service

* test(e2e): add test for adding and removing services from shoppin cart

* test(e2e): add test for shopping cart feature

* feat(web): add method to check if item is in cart

* refactor(api): apply suggestions from @mateus4k

Rename algolia variable for better readability

* refactor(web): remove resetIdCounter from home page as its in _document

* refactor(web): add lightGreen to theme object

Ty @mateus4k

* refactor(web): improve code readability

* test(web): update snapshot

* test(e2e): add coverage for creating a service when logged out

* chore(web): update react-number-format to prevent SSR issues

See s-yadav/react-number-format#481

* test(e2e): add cypress command to type into inputs

* test(e2e): add coverage for creating a service steps

* test: add shopping cart provider to render util

* test: add empty screen assertion for shopping art

* refactor(api): create query suggestions for services and remove unused attributes for faceting and filtering

* fix(api): check for original object properties when settings in algolia object

This is necessary because when starting to index an object we set default terms to prevent unexistent cases

* refactor(web): use util for getting browser env

* style(web): center cards

Co-authored-by: Luiz Felicio <[email protected]>
@natterstefan
Copy link
Contributor

natterstefan commented Jun 22, 2021

Hi @s-yadav,

I am sorry to tell you that I have the bug still with "react-number-format": "4.6.3". Can you still confirm that it's not an issue anymore?

Thanks for your time.


Edit: I created a PR to resolve the issue: #560.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment