Allow null value in TypeScript typing #347
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty trivial PR, but since you need to be able to set the
value
prop tonull
, seems like it should be allowed in the typings.That said, the behavior itself did confuse me. This line specifically, where you ignore the
value
prop if it isundefined
.... I guess you are usingvalue={undefined}
as a signal from the consumer that they want the NumberFormat to be stateful?Might be better to have an explicit
stateless
prop. But maybe there's just some inevitable confusion when you can use the same component in either way.I could add a bit to the readme about passing
null
if you are trying to use the NumberFormat as a stateless component.