Fix full value replacement issue when allowEmptyString is set to true #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test case
nikhil-varma
changed the title
s-yadav
approved these changes
Mar 28, 2021
This was referenced Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue/change
When the input gets value via the auto-complete feature of a browser and is
allowEmptyFormattingis allowed, it does not show the updated value and shows the old formatted string.Add CodeSandbox link to illustrate the issue (If applicable)
Describe specs for failing cases if this is an issue (If applicable)
Browser autocomplete replacing the whole value will not update the input field with the new value
Describe the changes proposed/implemented in this PR
The logic looks to validate if the selection is for the entire string and updates the value
Link Github issue if this PR solved an existing issue
#450
Example usage (If applicable)
No change in the usage
Screenshot (If applicable)
Please check which browsers were used for testing