Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get correct regular expression to sharing 'format' and 'customNumerals' props #594

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

aSosunoff
Copy link
Contributor

Sharing 'format' and 'customNumerals' props does not allow to enter symbols from the 'customNumerals' array.

Below i use your function getNumberRegex for get correct regular expression

@changelogg
Copy link

changelogg bot commented Nov 16, 2021

Hey! Changelogs info seems to be missing or might be in incorrect format.
Please use the below template in PR description to ensure Changelogg can detect your changes:
- (tag) changelog_text
or
- tag: changelog_text
OR
You can add tag in PR header or while doing a commit too
(tag) PR header
or
tag: PR header
Valid tags: added / feat, changed, deprecated, fixed / fix, removed, security, build, ci, chore, docs, perf, refactor, revert, style, test
Thanks!
For more info, check out changelogg docs

@aSosunoff aSosunoff changed the title Fix get regexp fix: get correct regular expression to sharing 'format' and 'customNumerals' props Nov 16, 2021
@s-yadav
Copy link
Owner

s-yadav commented Dec 1, 2021

Looks great, thanks for the PR.

@s-yadav s-yadav merged commit 2b7ae9e into s-yadav:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants