Migrate tests #763
Merged
Migrate tests #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore some contents of the .yarn directory
s-yadav
reviewed
Jun 10, 2023
.yarn/releases/yarn-1.22.19.cjs
Outdated
There was a problem hiding this comment.
Looks like this got staged and after that .yarn folder is added on gitignore. You will need to untrack the file.
There was a problem hiding this comment.
Yarn docs recommend committing .yarn/releases to the repo. The reasoning behind this is:
You will want to keep them (.yarn/plugins and .yarn/releases) versioned (this prevents potential issues if, say, two engineers use different Yarn versions with different features).
There was a problem hiding this comment.
The .yarn/releases directory contains whatever version of Yarn is being used. I can ignore it, but it is not recommended.
* Rename input.spec.js to input.spec.jsx
* Remove @testing-library/react-hooks
|
Merging this to the dev will work with main repo directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goals of this PR are:
Checklist: