Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nonEnglish number foramt, Persian, Arabic #874

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

baravak
Copy link

@baravak baravak commented Dec 19, 2024

Describe the issue/change

#525

Add CodeSandbox link to illustrate the issue (If applicable)

Describe specs for failing cases if this is an issue (If applicable)

Describe the changes proposed/implemented in this PR

Link Github issue if this PR solved an existing issue

Example usage (If applicable)

<NumberFormatBase nonEnglishFormat />
<NumericFormat nonEnglishFormat />
<PatternFormat nonEnglishFormat />

Screenshot (If applicable)

Please check which browsers were used for testing

  • Chrome
  • Chrome (Android)
  • Safari (OSX)
  • Safari (iOS)
  • Firefox
  • Firefox (Android)

@s-yadav
Copy link
Owner

s-yadav commented Dec 25, 2024

Hey @baravak, Have you tried the custom numeral example? Any issue coming with doing it outside. Most of the custom logic can be handled in removeFormat and format prop.
We are keeping it outside the library because there can be multiple numeral types.

https://s-yadav.github.io/react-number-format/docs/customization/#custom-numeral-example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants