chore: add targetCell values #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the ## [Unreleased] (already there)
### Added
- `targetCellWidth` and `targetCellHeight` options in config pluginand the docs wherever Also, did you try this on Android 11 or older? |
In Android 11 and Older , cell width is not supported hence it will pick only minWidth and minHeight values. |
sAleksovski
reviewed
May 12, 2024
app.plugin.ts
Outdated
| } | ||
| ${ | ||
| widget.targetCellHeight | ||
| ? ` android:targetCellWidth="${widget.targetCellHeight}"` |
There was a problem hiding this comment.
android:targetCellHeight instead of android:targetCellWidth
|
Thanks! I just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.android.com/develop/ui/views/appwidgets/layouts#anatomy_determining_size
minWidth or minHeight. According to docs , If defined, these attributes are used instead of minWidth or minHeight.