Add Intt Event Mixup QA #3201
Open
Add Intt Event Mixup QA #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build & test reportReport for commit d992284bf65528f03055b876804ed4df80534be9:
Automatically generated by sPHENIX Jenkins continuous integration |
osbornjd
requested changes
Oct 25, 2024
There was a problem hiding this comment.
This needs to be modified to use the QA framework for file handling so that all QA histograms go to the same place when the module is used in the production.
See here for an example of how to register QA histograms with the manager, and then you can get your macro to dump the histograms out using some code like this
…rrays of hists that will be plotted with a QAHistManager
Added name mangling with (default) QA module name, registered the 4 a…
|
I fixed some of the issues locally--I spoke with Mai and only 4 of the (arrays) of histograms are to be plotted. |
Build & test reportReport for commit 3e188154f621011685181c03eec6b07e071126c5:
Automatically generated by sPHENIX Jenkins continuous integration |
…rs, hopefully Jenkins is happy
Fixed (most, ignored "variable's scope can be reduced") cppcheck erro…
Build & test reportReport for commit a5c8329dcee8ad5557a749a3e8e7a01cd6c7920c:
Automatically generated by sPHENIX Jenkins continuous integration |
Fixed cppcheck errors caused by bcocheck.cc
Build & test reportReport for commit 8d28dec8a70aa7324d5cf9778036384849dd8c60:
Automatically generated by sPHENIX Jenkins continuous integration |
osbornjd
requested changes
Nov 22, 2024
There was a problem hiding this comment.
I fixed the clang-tidy issues from the CI but this still needs some work. You register the histograms now with the histogram manager which is great, but the only thing these modules should do is create the histograms, register them with the histogram manager, and then fill those histograms. The histogram manager will take care of the file creation and writing of the histograms for you. Then, the drawing of those histograms is delegated to a different module in github.com/sPHENIX-Collaboration/QAhtml . That means these modules should not do any drawing or other file creation - that is delegated to QAhtml.
Also in general you should not use Form and instead use the boost::format to create names of things. When we switch to c++20 soon then we can use std::format.
If you have questions about any of this, let's setup a time to chat and we can discuss how to go about it
Build & test reportReport for commit d21b7945e9d25757c263eedd2c18106f2a9efd58:
Automatically generated by sPHENIX Jenkins continuous integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bcocheck module make INTT BCO difference plot (BCO_Full - BCO) for getting trigger timing peak.
InttMixupQA module analyze hit mixed up from previous event.
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)