Zero field all layers

[adfrawley]

Types of changes

• [x ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

Fixes handling of crossing in HelicalFitter.

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

[sphenix-jenkins-ci]

Build & test report

Report for commit dcfba4339d64e703e9e784f9df607d34ca297875:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• Build with configuration of gcc-12.1.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, 📊 trends
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is SUCCESS, 📊 trends
    • 📊 QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = 1002.63 / 56, and combined p-Value = 1.48593e-173
    • 📊 QA-vertexing : combined Chi2/nDoF = 579.301 / 112, and combined p-Value = 3.95264e-64
  • Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = 252.223 / 72, and combined p-Value = 7.62301e-22
    • 📊 QA-Micromegas : combined Chi2/nDoF = 14.7898 / 20, and combined p-Value = 0.788309
    • 📊 QA-Mvtx : combined Chi2/nDoF = 903.722 / 54, and combined p-Value = 1.61955e-154
    • 📊 QA-Tpc : combined Chi2/nDoF = 168.947 / 56, and combined p-Value = 2.89723e-13
    • 📊 QA-tracking : combined Chi2/nDoF = 522.546 / 50, and combined p-Value = 6.16385e-80
    • 📊 QA-vertexing : combined Chi2/nDoF = 257.648 / 112, and combined p-Value = 1.72249e-13
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
• Build with configuration of gcc-12.1.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is UNSTABLE, 📊clang-tidy report (full)/(new)
• cpp-check is FAILURE, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration
           

[sphenix-jenkins-ci]

Build & test report

Report for commit 5696c9b951619207beff34f20ef16c8aab0cb6e3:

• builds and tests overall are SUCCESS.
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
• Build with configuration of gcc-12.1.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of gcc-12.1.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, 📊 trends
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = -0 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is SUCCESS, 📊 trends
    • 📊 QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = 1002.63 / 56, and combined p-Value = 1.48593e-173
    • 📊 QA-vertexing : combined Chi2/nDoF = 579.301 / 112, and combined p-Value = 3.95264e-64
  • Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = 252.223 / 72, and combined p-Value = 7.62301e-22
    • 📊 QA-Micromegas : combined Chi2/nDoF = 14.7898 / 20, and combined p-Value = 0.788309
    • 📊 QA-Mvtx : combined Chi2/nDoF = 903.722 / 54, and combined p-Value = 1.61955e-154
    • 📊 QA-Tpc : combined Chi2/nDoF = 171.429 / 56, and combined p-Value = 1.23373e-13
    • 📊 QA-tracking : combined Chi2/nDoF = 522.546 / 50, and combined p-Value = 6.16385e-80
    • 📊 QA-vertexing : combined Chi2/nDoF = 256.562 / 112, and combined p-Value = 2.35743e-13
  • system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
  • system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system gcc-12.1.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
• Build with configuration of gcc-12.1.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is UNSTABLE, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration
           

[osbornjd]

@adfrawley this improves the purity of the tracks but reduces the efficiency with which we find them in the simulation QA

[osbornjd]

@adfrawley this changed the track matching QA significantly and has merge conflicts now. Are you still working on this?

[sPHENIX-GitHub-l]

I have not been working on it. I will check if anything here is needed, and make a simplified PR if so. It can be closed.

…

________________________________ From: ***@***.*** ***@***.***> on behalf of "Joseph (Joe) Osborn" ***@***.***> Sent: Tuesday, February 11, 2025 4:07 PM To: sPHENIX-Collaboration/coresoftware ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [[Sphenix-github-l] ] [sPHENIX-Collaboration/coresoftware] Zero field all layers (PR #3295) @adfrawley<https://github.com/adfrawley> this changed the track matching QA significantly and has merge conflicts now. Are you still working on this? — Reply to this email directly, view it on GitHub<#3295 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEALMH4X3THV257PDCUB3DL2PJRAPAVCNFSM6AAAAABTL3XIWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJSGA3DSMBSHA>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>