New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to area rho method #3408

Open

tmengel wants to merge 3 commits into sPHENIX-Collaboration:master from tmengel:AreaRhoFix

Contributor

tmengel commented Feb 6, 2025

Removed fasjet::JetMedianBackgroundEstimator and replaced with a custom function to calculate area rho. Similar to multiplicity-based rho. Handles negative E towers correctly now

Types of changes

[ x] Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work for users)
Requiring change in macros repository (Please provide links to the macros pull request in the last section)
I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

Fixed the way DetermineTowerRho/DetermineEventRho calculates area-based rho:
https://indico.bnl.gov/event/26524/#sc-87-6-ppg-04-ue-in-auau

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)


          update to area rho method

a69215d

sphenix-jenkins-ci bot commented Feb 6, 2025

Build & test report

Report for commit a69215decccd96de2776ae30f78ec5eec4648ba1:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 3.7388 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 36.6822 / 72, and combined p-Value = 0.999828
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 2.32973e-05 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.3602 / 42, and combined p-Value = 0.986551
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration


          changed the verbosity of warning outputs

f7f8ee0

sphenix-jenkins-ci bot commented Feb 7, 2025

Build & test report

Report for commit f7f8ee0a53952dce67323015ea2330869c5cc7eb:

builds and tests overall are FAILURE.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 3.7388 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 36.7983 / 72, and combined p-Value = 0.999818
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 2.32973e-05 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.3602 / 42, and combined p-Value = 0.986551
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
clang-tidy is FAILURE, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration


          Merge branch 'sPHENIX-Collaboration:master' into AreaRhoFix

330b974

sphenix-jenkins-ci bot commented Feb 8, 2025

Build & test report

Report for commit 330b974fd022eca00dc22c5f2cd6f8bac9b0f18d:

builds and tests overall are FAILURE.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 3.7388 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 36.7983 / 72, and combined p-Value = 0.999818
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 2.32973e-05 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.3602 / 42, and combined p-Value = 0.986551
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
clang-tidy is FAILURE, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet