New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detailed calorimeter geometry #3414

Open

virgile-mahaut wants to merge 8 commits into sPHENIX-Collaboration:master from virgile-mahaut:DetailedCalorimeterGeometry

virgile-mahaut commented Feb 7, 2025

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work for users)
Requiring change in macros repository (Please provide links to the macros pull request in the last section)
I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

This PR adds the possibility to use an alternative version of the EMCal geometry in the calorimeter reconstruction software. In this new version, the tower centers are identical to those in the GEANT4 simulation. In addition, the new geometry class allows to access easily the 8 vertices of the tower as well as the center of each face. This new geometry has been mentioned in this talk: https://indico.bnl.gov/event/26075/contributions/101054/attachments/59317/101905/Calorimeter_cluster_reconstruction_01062025.pdf.

TODOs (if applicable)

Implement the new geometry in the cluster reconstruction code without breaking the former geometry.

Links to other PRs in macros and calibration repositories (if applicable)

This pull request has been done following this pull request (#3374) which has been closed. The style is now generated with clang-format. Formerly global typedefs and struct have been redefined inside the class RawTowerGeomv5. "signaling_NaN()" have been replaced by "quiet_NaN()", both in RawTowerGeomv5.h and in RawTowerGeom.h

Virgile Jean Alain Mahaut and others added 7 commits

January 21, 2025 05:19


          New detailed geometry class in calorimeter reconstruction

224cd0a


          Merge branch 'sPHENIX-Collaboration:master' into DetailedCalorimeterG…

48a4856

…eometry


          Merge branch 'sPHENIX-Collaboration:master' into DetailedCalorimeterG…

25defe4

…eometry


          Merge branch 'sPHENIX-Collaboration:master' into DetailedCalorimeterG…

1ebb773

…eometry


          Merge branch 'sPHENIX-Collaboration:master' into DetailedCalorimeterG…

a425a65

…eometry


          Fix coding conventions in the implementation of the new geometry

03c827e


          Merge branch 'sPHENIX-Collaboration:master' into DetailedCalorimeterG…

a287f00

…eometry

sphenix-jenkins-ci bot commented Feb 7, 2025

Build & test report

Report for commit a287f002944805ce116bf1c3f6aa7443934e9ebe:

builds and tests overall are FAILURE.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 3.7388 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 36.7983 / 72, and combined p-Value = 0.999818
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 2.32973e-05 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.3602 / 42, and combined p-Value = 0.986551
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
clang-tidy is FAILURE, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration


          Small clang-tidy fix

2b10d4a

sphenix-jenkins-ci bot commented Feb 8, 2025

Build & test report

Report for commit 2b10d4a0f5ffb76eb80e132c30c900bd888f37d2:

builds and tests overall are FAILURE.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 3.7388 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 36.7983 / 72, and combined p-Value = 0.999818
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 2.32973e-05 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.3602 / 42, and combined p-Value = 0.986551
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
clang-tidy is FAILURE, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet