Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fig but in PHCASeeding #3416

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

david-stewart
Copy link
Contributor

The calculation of dphi from point A to point B was atan2(By,Bx) - atan2(Ay,By). This fails for values at -Ax and -Bx, where Ay and By change sign (the periodic boundary). This is now fixed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

The calculation of dphi from point A to point B was
atan2(By,Bx) - atan2(Ay,By). This fails for values at -Ax and -Bx,
where Ay and By change sign (the periodic boundary). This is
now fixed.
@sphenix-jenkins-ci
Copy link

Build & test report

Report for commit b633c182327e27c030b5a0ca67f1919a9131e928:
Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@osbornjd osbornjd merged commit bc05b74 into sPHENIX-Collaboration:master Feb 10, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants