-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pull request branch configuration #40
Add pull request branch configuration #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the PR! 👍
By default the branch is now static, and the name is
gh-actions-update
.
I think we should not change current behavior (default) unless there is a big reason. The current behavior should be the default and the user can use pull_request_branch
option to change the default behavior (e.g. branch name set by pull_request_branch
will be used to create pull request or force push)
We also need to check if the pull request is already created or not with the users branch and only create pull request if it is not created, otherwise just force push.
Hi @saadmk11, Did you had time to check the update of the PR ? Best regards. |
Sorry, I have been quite busy. I'll try to take a look some time next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. I have requested some changes.
We need to update https://github.com/saadmk11/github-actions-version-updater/blob/main/action.yaml with the input option.
I will edit the PR ASAP. Thanks for the review.
I wasn't aware of this file. I will update it as well. Thanks. |
Done. I am unsure about the |
PR updated with the requested changes. In theory it should work. Do you have any way to test the feature before to merge it ? |
Hi @saadmk11, Quick reminder, could you test and review this PR? You might still be busy. Best regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jmlemetayer, Thanks for your work on this. For now I am merging the changes to a different branch as I need to do some manual testing.
Thanks, @saadmk11 I think I can also update one of my project using the action to use the development branch. I will keep you updated. |
I have updated my project: https://github.com/jmlemetayer/project-release/ To use:
Also I have add jmlemetayer/project-release@63be594 as a possible workaround of the #49 |
Updated my project again, with the fix of the #49. I let the action run twice, to see the pull request creation and update. Both run are a success:
I have checked manually that the created pull request is correct and also successfully updated: Looks good to me ! |
This fixes #39
There is 2 new configuration:
pull_request_branch
: The pull request branch name.pull_request_unique
: Is the pull request branch unique? If"false"
the branch will be suffixed with a timestamp.By default the branch is not unique and is suffixed with a timestamp, and the name is
gh-actions-update
.The current default behavior is unchanged.