Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): switch from gatsby to next #612

Merged
merged 1 commit into from
Apr 24, 2022
Merged

feat(next): switch from gatsby to next #612

merged 1 commit into from
Apr 24, 2022

Conversation

sabertazimi
Copy link
Owner

BREAKING CHANGE: switch from gatsby to next

Pull Request

This PR Contains

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Test-Case

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Additional Info

@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #612 (4287868) into main (37dab36) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main      #612    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           44        64    +20     
  Lines          208       423   +215     
  Branches        40        38     -2     
==========================================
+ Hits           208       423   +215     
Impacted Files Coverage Δ
components/Article/Article.tsx 100.00% <ø> (ø)
components/Article/ArticleDivider.tsx 100.00% <ø> (ø)
components/Article/index.ts 100.00% <ø> (ø)
components/BooksGrid/BookCard.tsx 100.00% <ø> (ø)
components/BooksGrid/BooksGrid.tsx 100.00% <ø> (ø)
components/BooksGrid/index.ts 100.00% <ø> (ø)
components/Container/Container.tsx 100.00% <ø> (ø)
components/Container/index.ts 100.00% <ø> (ø)
components/ErrorBoundary/ErrorBoundary.tsx 100.00% <ø> (ø)
components/ErrorBoundary/index.ts 100.00% <ø> (ø)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37dab36...4287868. Read the comment docs.

@sabertazimi sabertazimi force-pushed the next branch 6 times, most recently from 13db2a4 to b23211b Compare April 24, 2022 06:34
BREAKING CHANGE: switch from `gatsby` to `next`
@pull-request-quantifier-deprecated

This PR has 2125 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +806 -1319
Percentile : 100%

Total files changed: 91

Change summary by file extension:
.eslintignore : +0 -8
.json : +43 -127
.yml : +3 -67
.gitignore : +13 -6
.md : +22 -61
.ts : +208 -328
.tsx : +481 -230
.snap : +0 -0
.js : +36 -292
.css : +0 -200

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@sabertazimi sabertazimi merged commit 3c4a151 into main Apr 24, 2022
@sabertazimi sabertazimi deleted the next branch April 24, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant