refactor: address feedback #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @andreivladbrg. Since we have agreed to revert changes on the following two comments:
Can you please revert them? I would make it easy to review this given functions selection in Helpers would also change. |
refactor: revert constant in library change refactor: re introduce _checkCliffAndEndTime function
|
@smol-ninja just pushed a commit to revert the 2 things, and i've also moved the calculate segments/tranches in Helpers |
smol-ninja
requested changes
Nov 8, 2024
andreivladbrg
merged commit 5634eff
into
refactor/singleton-contract
7 of 8 checks passed
smol-ninja
added a commit
that referenced
this pull request
Nov 8, 2024
* refactor: address feedback * refactor: move calculate segments/tranches in Helpers refactor: revert constant in library change refactor: re introduce _checkCliffAndEndTime function * refactor: polish code * chore: remove unneeded import * add stream id in _create * use ISablierLockupBase.isTransferable --------- Co-authored-by: smol-ninja <[email protected]>
andreivladbrg
pushed a commit
that referenced
this pull request
Nov 11, 2024
refactor: modifies Datatypes refactor: deletes individual lockup contracts and interfaces feat: adds SablierLockupBase and SablierLockup feat: spin out VestingMath library out of Helpers library refactor: update errors refactor: make periphery and merkle lockup contracts compatible with singelton lockup chore: update count of inherited components chore: update deployment scripts build: update shell scripts chore: update precompiles contract style: fix lint warnings feat: include libraries in artifacts fix: bug refactor: move endTime check into helpers refactor: address feedback (#1079) * refactor: address feedback * refactor: move calculate segments/tranches in Helpers refactor: revert constant in library change refactor: re introduce _checkCliffAndEndTime function * refactor: polish code * chore: remove unneeded import * add stream id in _create * use ISablierLockupBase.isTransferable --------- Co-authored-by: smol-ninja <[email protected]> refactor: prefix errors name used in Helpers with SablierHelpers
smol-ninja
added a commit
that referenced
this pull request
Nov 11, 2024
refactor: modifies Datatypes refactor: deletes individual lockup contracts and interfaces feat: adds SablierLockupBase and SablierLockup feat: spin out VestingMath library out of Helpers library refactor: update errors refactor: make periphery and merkle lockup contracts compatible with singelton lockup chore: update count of inherited components chore: update deployment scripts build: update shell scripts chore: update precompiles contract style: fix lint warnings feat: include libraries in artifacts fix: bug refactor: move endTime check into helpers refactor: address feedback (#1079) * refactor: address feedback * refactor: move calculate segments/tranches in Helpers refactor: revert constant in library change refactor: re introduce _checkCliffAndEndTime function * refactor: polish code * chore: remove unneeded import * add stream id in _create * use ISablierLockupBase.isTransferable --------- Co-authored-by: smol-ninja <[email protected]> refactor: prefix errors name used in Helpers with SablierHelpers
smol-ninja
added a commit
that referenced
this pull request
Nov 11, 2024
feat: adds ISablierLockup and ISablierLockupBase refactor: modifies Datatypes refactor: deletes individual lockup contracts and interfaces feat: adds SablierLockupBase and SablierLockup feat: spin out VestingMath library out of Helpers library refactor: update errors refactor: make periphery and merkle lockup contracts compatible with singelton lockup chore: update count of inherited components chore: update deployment scripts build: update shell scripts chore: update precompiles contract style: fix lint warnings feat: include libraries in artifacts fix: bug refactor: move endTime check into helpers refactor: address feedback (#1079) * refactor: address feedback * refactor: move calculate segments/tranches in Helpers refactor: revert constant in library change refactor: re introduce _checkCliffAndEndTime function * refactor: polish code * chore: remove unneeded import * add stream id in _create * use ISablierLockupBase.isTransferable refactor: prefix errors name used in Helpers with SablierHelpers --------- Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
andreivladbrg
added a commit
that referenced
this pull request
Nov 13, 2024
feat: adds ISablierLockup and ISablierLockupBase refactor: modifies Datatypes refactor: deletes individual lockup contracts and interfaces feat: adds SablierLockupBase and SablierLockup feat: spin out VestingMath library out of Helpers library refactor: update errors refactor: make periphery and merkle lockup contracts compatible with singelton lockup chore: update count of inherited components chore: update deployment scripts build: update shell scripts chore: update precompiles contract style: fix lint warnings feat: include libraries in artifacts fix: bug refactor: move endTime check into helpers refactor: address feedback (#1079) * refactor: address feedback * refactor: move calculate segments/tranches in Helpers refactor: revert constant in library change refactor: re introduce _checkCliffAndEndTime function * refactor: polish code * chore: remove unneeded import * add stream id in _create * use ISablierLockupBase.isTransferable refactor: prefix errors name used in Helpers with SablierHelpers --------- Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
andreivladbrg
added a commit
that referenced
this pull request
Nov 13, 2024
feat: adds ISablierLockup and ISablierLockupBase refactor: modifies Datatypes refactor: deletes individual lockup contracts and interfaces feat: adds SablierLockupBase and SablierLockup feat: spin out VestingMath library out of Helpers library refactor: update errors refactor: make periphery and merkle lockup contracts compatible with singelton lockup chore: update count of inherited components chore: update deployment scripts build: update shell scripts chore: update precompiles contract style: fix lint warnings feat: include libraries in artifacts fix: bug refactor: move endTime check into helpers refactor: address feedback (#1079) * refactor: address feedback * refactor: move calculate segments/tranches in Helpers refactor: revert constant in library change refactor: re introduce _checkCliffAndEndTime function * refactor: polish code * chore: remove unneeded import * add stream id in _create * use ISablierLockupBase.isTransferable refactor: prefix errors name used in Helpers with SablierHelpers --------- Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
andreivladbrg
added a commit
that referenced
this pull request
Jan 27, 2025
feat: adds ISablierLockup and ISablierLockupBase refactor: modifies Datatypes refactor: deletes individual lockup contracts and interfaces feat: adds SablierLockupBase and SablierLockup feat: spin out VestingMath library out of Helpers library refactor: update errors refactor: make periphery and merkle lockup contracts compatible with singelton lockup chore: update count of inherited components chore: update deployment scripts build: update shell scripts chore: update precompiles contract style: fix lint warnings feat: include libraries in artifacts fix: bug refactor: move endTime check into helpers refactor: address feedback (#1079) * refactor: address feedback * refactor: move calculate segments/tranches in Helpers refactor: revert constant in library change refactor: re introduce _checkCliffAndEndTime function * refactor: polish code * chore: remove unneeded import * add stream id in _create * use ISablierLockupBase.isTransferable refactor: prefix errors name used in Helpers with SablierHelpers --------- Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses my feedback in #1069.
Some of the changes will be discussed in the comments left under that PR.