Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change "expected" wording #20

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

PaulRBerg
Copy link
Member

@PaulRBerg PaulRBerg commented Dec 14, 2023

Implements the feedback left in #19.

I've gone with aggregateAmount because that's the wording used in Solidity + to avoid conflicts with totalAmount in V2 Core.

refactor: change "expectedRecipients" to "totalRecipients"
@PaulRBerg PaulRBerg requested a review from razgraf December 14, 2023 17:07
@PaulRBerg PaulRBerg changed the title refactor: change expected refactor: change "expected" wording Dec 14, 2023
@razgraf razgraf merged commit 72a9277 into feat/v2.1 Dec 18, 2023
@razgraf razgraf deleted the refactor/change-expected branch December 18, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants