refactor: withdraw related notes #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
requested changes
Jan 12, 2024
smol-ninja
force-pushed
the
fix/missing-changes
branch
from
4b33e2a to
5c88e5c
Compare
smol-ninja
force-pushed
the
fix/missing-changes
branch
from
5c88e5c to
742ec20
Compare
andreivladbrg
approved these changes
Jan 12, 2024
andreivladbrg
pushed a commit
that referenced
this pull request
Jan 21, 2024
smol-ninja
added a commit
that referenced
this pull request
Jan 23, 2024
* feat: `withdraw` function callable by any account feat: `withdrawMultiple` calls withdraw on streams recipient test: fuzz test for with when the caller is an unknown address refactor: rename custom error chore: improve explanatory comments test: undo authorized test branches test: say uknown address instead of public caller test: make withdraw fuzz test more minimalist * refactor: withdraw related notes (#791) * docs: improve writing in NatSpec comments refactor: reorder errors test: improve names for functions and variables * refactor: withdraw tree * refactor: order of checks in "withdraw" test: polish withdraw tree and tests --------- Co-authored-by: Paul Razvan Berg <[email protected]>
andreivladbrg
pushed a commit
that referenced
this pull request
Feb 12, 2024
* feat: `withdraw` function callable by any account feat: `withdrawMultiple` calls withdraw on streams recipient test: fuzz test for with when the caller is an unknown address refactor: rename custom error chore: improve explanatory comments test: undo authorized test branches test: say uknown address instead of public caller test: make withdraw fuzz test more minimalist * refactor: withdraw related notes (#791) * docs: improve writing in NatSpec comments refactor: reorder errors test: improve names for functions and variables * refactor: withdraw tree * refactor: order of checks in "withdraw" test: polish withdraw tree and tests --------- Co-authored-by: Paul Razvan Berg <[email protected]>
andreivladbrg
pushed a commit
that referenced
this pull request
Feb 15, 2024
* feat: `withdraw` function callable by any account feat: `withdrawMultiple` calls withdraw on streams recipient test: fuzz test for with when the caller is an unknown address refactor: rename custom error chore: improve explanatory comments test: undo authorized test branches test: say uknown address instead of public caller test: make withdraw fuzz test more minimalist * refactor: withdraw related notes (#791) * docs: improve writing in NatSpec comments refactor: reorder errors test: improve names for functions and variables * refactor: withdraw tree * refactor: order of checks in "withdraw" test: polish withdraw tree and tests --------- Co-authored-by: Paul Razvan Berg <[email protected]>
andreivladbrg
pushed a commit
that referenced
this pull request
Feb 17, 2024
* feat: `withdraw` function callable by any account feat: `withdrawMultiple` calls withdraw on streams recipient test: fuzz test for with when the caller is an unknown address refactor: rename custom error chore: improve explanatory comments test: undo authorized test branches test: say uknown address instead of public caller test: make withdraw fuzz test more minimalist * refactor: withdraw related notes (#791) * docs: improve writing in NatSpec comments refactor: reorder errors test: improve names for functions and variables * refactor: withdraw tree * refactor: order of checks in "withdraw" test: polish withdraw tree and tests --------- Co-authored-by: Paul Razvan Berg <[email protected]>
andreivladbrg
pushed a commit
that referenced
this pull request
Jul 3, 2024
* feat: `withdraw` function callable by any account feat: `withdrawMultiple` calls withdraw on streams recipient test: fuzz test for with when the caller is an unknown address refactor: rename custom error chore: improve explanatory comments test: undo authorized test branches test: say uknown address instead of public caller test: make withdraw fuzz test more minimalist * refactor: withdraw related notes (#791) * docs: improve writing in NatSpec comments refactor: reorder errors test: improve names for functions and variables * refactor: withdraw tree * refactor: order of checks in "withdraw" test: polish withdraw tree and tests --------- Co-authored-by: Paul Razvan Berg <[email protected]>
andreivladbrg
pushed a commit
that referenced
this pull request
Jul 3, 2024
* feat: `withdraw` function callable by any account feat: `withdrawMultiple` calls withdraw on streams recipient test: fuzz test for with when the caller is an unknown address refactor: rename custom error chore: improve explanatory comments test: undo authorized test branches test: say uknown address instead of public caller test: make withdraw fuzz test more minimalist * refactor: withdraw related notes (#791) * docs: improve writing in NatSpec comments refactor: reorder errors test: improve names for functions and variables * refactor: withdraw tree * refactor: order of checks in "withdraw" test: polish withdraw tree and tests --------- Co-authored-by: Paul Razvan Berg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #785