refactor: return the withdrawn amount #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
requested review from
smol-ninja and
PaulRBerg
and removed request for
smol-ninja
test: the return value in withdrawMax and withdrawMaxAndTransfer
andreivladbrg
force-pushed
the
refactor/return-value
branch
from
8e63927 to
5f9e6f9
Compare
smol-ninja
requested changes
Jul 1, 2024
test/integration/concrete/lockup/withdraw-max-and-transfer/withdrawMaxAndTransfer.t.sol
Show resolved
Hide resolved
test/integration/concrete/lockup/withdraw-max-and-transfer/withdrawMaxAndTransfer.tree
Outdated
Show resolved
Hide resolved
smol-ninja
approved these changes
Jul 1, 2024
Merged
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
…axAndTransfer (#961) * refactor: return the withdrawn amount test: the return value in withdrawMax and withdrawMaxAndTransfer * chore: update precompiles * shub feedback
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
…axAndTransfer (#961) * refactor: return the withdrawn amount test: the return value in withdrawMax and withdrawMaxAndTransfer * chore: update precompiles * shub feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #955