Install dependencies with Node.js instead of git modules #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add BaseScript chore: update remappings chore: update imports
andreivladbrg
force-pushed
the
build/modules-to-npm
branch
3 times, most recently
from
28c68a6 to
1b9e184
Compare
build: remove git modules chore: update remappings and imports accordingly ci: cache the node_modules in build job to re-use it other jobs
andreivladbrg
force-pushed
the
build/modules-to-npm
branch
from
1b9e184 to
9b0b058
Compare
PaulRBerg
reviewed
Dec 17, 2023
| @@ -6,7 +6,7 @@ import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol"; | |||
| import { SafeERC20 } from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol"; | |||
| import { ISablierV2LockupLinear } from "@sablier/v2-core/src/interfaces/ISablierV2LockupLinear.sol"; | |||
| import { Broker, LockupLinear } from "@sablier/v2-core/src/types/DataTypes.sol"; | |||
| import { ud } from "@sablier/v2-core/src/types/Math.sol"; | |||
| import { ud } from "@prb/math/src/UD60x18.sol"; | |||
There was a problem hiding this comment.
Just realized that by removing these reexports we have technically introduced a breaking change.
We didn't mark this change as "Breaking" in the changelog in V2 Core.
But it's a small thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from using git modules to NPM
Similar to sablier-labs/lockup#734