Correctly process a POST with no Content-Type specified

sabre-io · Feb 4, 2021 · a5d3496 · a5d3496
1 parent 4258420
commit a5d3496
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/DAV/Browser/Plugin.php b/lib/DAV/Browser/Plugin.php
@@ -157,6 +157,9 @@ public function httpGet(RequestInterface $request, ResponseInterface $response)
     public function httpPOST(RequestInterface $request, ResponseInterface $response)
     {
         $contentType = $request->getHeader('Content-Type');
+        if (!\is_string($contentType)) {
+            return;
+        }
         list($contentType) = explode(';', $contentType);
         if ('application/x-www-form-urlencoded' !== $contentType &&
             'multipart/form-data' !== $contentType) {

diff --git a/tests/Sabre/DAV/Browser/PluginTest.php b/tests/Sabre/DAV/Browser/PluginTest.php
@@ -104,6 +104,15 @@ public function testPostOtherContentType()
         $this->assertEquals(501, $this->response->status);
     }
 
+    public function testPostNoContentType()
+    {
+        $request = new HTTP\Request('POST', '/', []);
+        $this->server->httpRequest = $request;
+        $this->server->exec();
+
+        $this->assertEquals(501, $this->response->status);
+    }
+
     public function testPostNoSabreAction()
     {
         $request = new HTTP\Request('POST', '/', ['Content-Type' => 'application/x-www-form-urlencoded']);