-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky tests #845
Merged
Merged
Fix flaky tests #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalapatil
changed the title
Fix /spec/requests/internal_api/v1/team_members/details/update_spec.r…
Fix team flaky test
Dec 13, 2022
Current Code Coverage Percent of this PR:90.13 %Files having coverage below 100%
|
swaathi
suggested changes
Dec 13, 2022
swaathi
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and merging. Updating user factory in another PR.
pr-triage
bot
added
PR: reviewed-approved
and removed
PR: reviewed-changes-requested
labels
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion card
Summary
Fixed the following flaky specs:
InternalApi::V1::TeamMembers::DetailsController::#update when Employee wants to update his own details is successful Failure/Error: expect(response).to have_http_status(:ok) expected the response to have status code :ok (200) but it was :unprocessable_entity ([42](https://github.com/saeloun/miru-web/actions/runs/3673181224/jobs/6212369080#step:20:43)2) # ./spec/requests/internal_api/v1/team_members/details/update_spec.rb:83:in
block (3 levels) in <top (required)>'`Problem was, in lastname param, we expect only alphabets and sometimes faker was adding
'
in the string while generating last nameFix: Spec was not able to get document from the ES, added index refresh call.
Preview
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: