Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weak test #1562

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Fix weak test #1562

merged 2 commits into from
Feb 17, 2025

Conversation

moisses89
Copy link
Member

@moisses89 moisses89 commented Feb 17, 2025 •
edited
Loading

Description

Accept different exceptions that depends on RPC side.

@moisses89 moisses89 requested a review from a team as a code owner February 17, 2025 12:37
@coveralls
Copy link

coveralls commented Feb 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13370904713

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 93.92%
Changes Missing Coverage Covered Lines Changed/Added Lines %
safe_eth/eth/tests/test_ethereum_client.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
safe_eth/eth/clients/etherscan_client.py 1 85.87%
safe_eth/eth/ethereum_client.py 1 85.21%
safe_eth/eth/tests/clients/test_etherscan_client_v2.py 1 86.11%
Totals Coverage Status
Change from base Build 13367138005: -0.03%
Covered Lines: 9484
Relevant Lines: 10098
💛 - Coveralls

@moisses89 moisses89 force-pushed the accept_other_exceptions branch from 5a3b73d to ef2c430 Compare February 17, 2025 13:03
@moisses89 moisses89 merged commit 7ba475c into main Feb 17, 2025
7 checks passed
@moisses89 moisses89 deleted the accept_other_exceptions branch February 17, 2025 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

@Uxio0 Uxio0 Uxio0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moisses89 @coveralls @falvaradorodriguez @Uxio0