Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChainInfo['contractAddresses'] property #187

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Add ChainInfo['contractAddresses'] property #187

merged 2 commits into from
Jul 16, 2024

Conversation

iamacook
Copy link
Member

Summary

This adds the new contractAddresses object to the ChainInfo entity according to their inclusion in the Safe Client Gateway and Safe Config. Service.

Reasoning: the Web currently relies on the safe-deployments package to initialise the SDK. This means, in order to run our infrastructure, addresses need be added to the aforementioned package. The values of contractAddresses map 1:1 with the ContractNetworksConfig) of the protocol-kit making initialisation without presence in safe-deployments possible.

Changes

  • Add new (0x${string} | null) fields to ChainInfo['contractAddresses']:
    • safeSingletonAddress
    • safeProxyFactoryAddress
    • multiSendAddress
    • multiSendCallOnlyAddress
    • fallbackHandlerAddress
    • signMessageLibAddress
    • createCallAddress
    • simulateTxAccessorAddress
    • safeWebAuthnSignerFactoryAddress

@iamacook iamacook self-assigned this Jul 15, 2024
@iamacook iamacook changed the title Contract addresses Add ChainInfo['contractAddresses'] property Jul 15, 2024
@iamacook iamacook marked this pull request as draft July 15, 2024 09:47
@iamacook iamacook marked this pull request as ready for review July 16, 2024 07:14
katspaugh
katspaugh approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! 🙏

@katspaugh katspaugh merged commit a7d2769 into main Jul 16, 2024
4 checks passed
@katspaugh katspaugh deleted the contract-addresses branch July 16, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamacook @katspaugh