Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Swaps): add executedFee and executedFeeToken #210

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

iamacook
Copy link
Member

Summary

CoW will be deprecated executedSurplusFee, favouring executedFee and executedFeeToken in its place.

The propagates the associated changes on the Client Gateway to the SDK.

Change

  • Mark executedSurplusFee as deprecated
  • Remove undefined as a potential executedSurplusFee type
  • Add executedFee and executedFeeToken

@iamacook iamacook requested a review from katspaugh January 20, 2025 15:15
@iamacook iamacook self-assigned this Jan 20, 2025
@iamacook iamacook merged commit 7b53ccf into main Jan 20, 2025
4 checks passed
@iamacook iamacook deleted the deprecate-executed-surplus-fee branch January 20, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants