Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: TypeScript in tests #49

Merged
merged 9 commits into from
Dec 21, 2021
Merged

Chore: TypeScript in tests #49

merged 9 commits into from
Dec 21, 2021

Conversation

katspaugh
Copy link
Member

Resolves #46 and #8

How?

  • I've converted the unit tests to TypeScript
  • Added a test that simply imports a few random types from the package index

Extra

  • I've also unified the endpoints to not have a trailing slash

@katspaugh katspaugh requested a review from iamacook December 21, 2021 09:39
@github-actions
Copy link

github-actions bot commented Dec 21, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@katspaugh katspaugh merged commit 9e50873 into main Dec 21, 2021
@katspaugh katspaugh deleted the types branch December 21, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a test for type imports
2 participants